Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop Alerts/Subscribe, Contact & All Reports pages #102

Open
schlos opened this issue Aug 24, 2021 · 13 comments
Open

Develop Alerts/Subscribe, Contact & All Reports pages #102

schlos opened this issue Aug 24, 2021 · 13 comments
Labels
enhancement New feature or request help wanted Extra attention is needed html/css js

Comments

@schlos
Copy link
Member

schlos commented Aug 24, 2021

Is your feature request related to a problem? Please describe.

Milestone 5 - Alerts/Subscribe i Kontakt + Dashboard (All reports) pages

Describe the solution you'd like

As per Figma design: https://www.figma.com/file/OrvZfg5BsfdOzeL7nhRpEI/Popravi.to

Describe alternatives you've considered

Additional context

Gists with base template code for these pages:

@schlos schlos added enhancement New feature or request help wanted Extra attention is needed labels Aug 24, 2021
@schlos schlos added this to To do in Popravi.to priorities via automation Aug 24, 2021
@schlos schlos changed the title Develop Alerts/Subscribe, Contact & All Reports pages popravito: Develop Alerts/Subscribe, Contact & All Reports pages Aug 24, 2021
@schlos schlos moved this from Backlog to Development to-do in Popravi.to priorities Aug 24, 2021
@schlos schlos assigned schlos and barbaraperic and unassigned schlos Aug 26, 2021
@schlos
Copy link
Member Author

schlos commented Aug 26, 2021

@barbaraperic please preuzmi ova 3 pagea za implementaciju. Napravi form projekta, pa developaj na forkanom projektu kod sebe pa kada si gotova, posalji Pull Request.

Na linlku se nalazi zavrsen HTML od Silvije koji sadrzi ta 3 pagea: https://drive.google.com/file/d/1wS_feNEopHBk9Ji2u66Bex3okye27azd/view?usp=sharing (link content shared internally only)

Ako imas pitanja, pisi meni i/ili Silviji.

@schlos
Copy link
Member Author

schlos commented Aug 30, 2021

Handover biljeske od Silvije za ovaj preostali, zadnji milestone:

Ovdje su svi HTML-ovi iz prve etape kad sam sastavljala samo HTML i SCSS prema dizajnu, a za ovu zadnju etapu potrebni su samo notifications.html, all_reports.html i contact.html. Tu su i SCSS datoteke i slike koje sam preuzela iz dizajna u Figmi

Evo usporedba za stranicu Profil, my.html iz originalne mape base/my https://github.com/codeforcroatia/popravi.to/blob/develop/templates/web/base/my/my.html a evo kako sam ja to napravila https://github.com/codeforcroatia/popravi.to/blob/develop/templates/web/popravito/my/my.html pa pogledaj na nekim ostalim stranicama na našem popravito repozitoriju, možda ima i boljih primjera. Uglavnom princip copy/paste koda koji planiram izmjeniti dodavanjem custom klase ili nekog div-a iz foldera base, a ono što ne mislim mijenjati nisam ni dirala :)

https://github.com/codeforcroatia/popravi.to/tree/develop/web/cobrands/popravito Ovdje je sav naš custom SCSS i JavaScript te slike, inače u cobrands folderu ne postoji base folder za bazični stil, već je bazični folder u ovom slučaju fixmystreet.com ako trebaš za referencu.

@barbaraperic
Copy link
Collaborator

barbaraperic commented Aug 31, 2021 via email

@schlos
Copy link
Member Author

schlos commented Aug 31, 2021

Hej @barbaraperic ,
dobro si razumjela. Prvo napravi klon ovog naseg repoa, pa komitas promjene u svoj repo i onda napravis Pull Request na ovaj repo.

Ako ti treba pomoc oko koraka / flowa, javi mi pa mozmeo meet napraviti.

Pozz

@barbaraperic
Copy link
Collaborator

barbaraperic commented Aug 31, 2021 via email

@schlos
Copy link
Member Author

schlos commented Aug 31, 2021

@barbaraperic ajmo se cuti na Google Meet. Poslao sam ti invite na email. Ja sam vec u callu.

@schlos
Copy link
Member Author

schlos commented Sep 11, 2021

Contacts page - DONE

@schlos
Copy link
Member Author

schlos commented Sep 17, 2021

All Reports page - IN PROGRESS

@schlos
Copy link
Member Author

schlos commented Nov 12, 2021

Contact page - remaining:

@schlos
Copy link
Member Author

schlos commented Nov 12, 2021

Alerts page - remaining:

  • add top menu (i.e. INCLUDE, see example line here and here)
  • add footer (i.e. INCLUDE, see example here)
  • add left and right margins for page content
  • add design to area selection page (e.g. /alert/list?latitude=45.812841;longitude=15.975893)

@schlos
Copy link
Member Author

schlos commented Nov 14, 2021

Commit: 9691986 via PR #177

@schlos
Copy link
Member Author

schlos commented Nov 26, 2021

How to contribute?
Read our contribution guidelines at https://codeforcroatia.org/popravito-contribution-guidelines.

@schlos schlos changed the title popravito: Develop Alerts/Subscribe, Contact & All Reports pages Develop Alerts/Subscribe, Contact & All Reports pages Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed html/css js
Projects
Popravi.to priorities
  
Development in progress
Development

No branches or pull requests

2 participants