Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "layout-breve" class from widget template #45

Open
verythorough opened this issue May 2, 2016 · 0 comments
Open

Remove "layout-breve" class from widget template #45

verythorough opened this issue May 2, 2016 · 0 comments

Comments

@verythorough
Copy link

The "layout-breve" class adds a margin around the content of the widget iframe, adding awkward and unnecessary whitespace:
current

Considering that sites will generally style the iframe itself to conform to the desired layout, "layout-breve" seems undesireable in this context. Without it, the cards fill the iframe space, making the left margin an vertical whitespace pattern match with the rest of the page:
no-class

The one downside is that there is no margin between the cards and the vertical scrollbar. Setting the containing ul width to 99% via inline style would fix this, though it is a little hacky. (Ideally, this would be solved by making a lightweight widget-specific style list to replace the 6+ stylesheets currently being loaded in the iframe, but that's an issue I'll file separately.) If there are no objections to this, I'll make these changes and submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant