Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to read property "commit" on string #408

Open
NawrasBukhari opened this issue Dec 13, 2022 · 0 comments
Open

Attempt to read property "commit" on string #408

NawrasBukhari opened this issue Dec 13, 2022 · 0 comments

Comments

@NawrasBukhari
Copy link

NawrasBukhari commented Dec 13, 2022 •
edited

happened when tried to use the quick start by using it in the routes
image
NawrasBukhari added a commit to NawrasBukhari/laravel-selfupdater that referenced this issue Dec 13, 2022
@NawrasBukhari
fix %5C issue in the call
17ff1c7 
codedge#408 
when I debugged the issue it was with the coma separator constant so when I changed it worked
@NawrasBukhari NawrasBukhari mentioned this issue Dec 13, 2022
Open
NawrasBukhari added a commit to NawrasBukhari/laravel-selfupdater that referenced this issue Dec 16, 2022
@NawrasBukhari
replacing DIRECTORY_SEPARATOR
b408279 
I have replaced this const with custom helper function as a fix for issue: codedge#408
@NawrasBukhari NawrasBukhari mentioned this issue Dec 16, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NawrasBukhari