Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Tesla as wrapper to supports multiple http client #233

Open
Matsa59 opened this issue Feb 13, 2023 · 1 comment
Open

Use Tesla as wrapper to supports multiple http client #233

Matsa59 opened this issue Feb 13, 2023 · 1 comment

Comments

@Matsa59
Copy link

Matsa59 commented Feb 13, 2023

Is your feature request related to a problem? Please describe.

We moved from HTTPoison to hackney using Tesla but pigeon use directly HTTPoison create a dep that we could easily avoid.

Describe the solution you'd like

Replace HTTPoison by Tesla to support more http client.

After reading the code base it sounds really easy to do. I can do it but I prefer to ask if this direction is ok for the community.
At the end, people could continue to use HTTPoison if they prefer to

@hpopp
Copy link
Member

hpopp commented Feb 18, 2023

I agree that migrating to Tesla would be really nice, but there's a lot more to consider than the current HTTPoison usage in Pigeon. If we were to make such a change, I would want to deprecate Kadabra and update FCM and APNS to use Tesla as well. This introduces a lot of other considerations (eg, Tesla would have to use an HTTP/2-compliant adapter).

Let me think on it for a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants