Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elixir 1.12 Supervisor Deprecation #220

Open
d-wire opened this issue Feb 18, 2022 · 1 comment
Open

Elixir 1.12 Supervisor Deprecation #220

d-wire opened this issue Feb 18, 2022 · 1 comment

Comments

@d-wire
Copy link

d-wire commented Feb 18, 2022

Environment

  • Elixir 1.12.3 (compiled with Erlang/OTP 24)
  • Operating system: Mac OS Monterey (12.0.1)

Current behavior

When upgrading our Elixir version from 1.11 to 1.12, we started seeing deprecation warnings around how Pigeon was starting supervisors:

warning: Supervisor.Spec.worker/3 is deprecated. Use the new child specifications outlined in the Supervisor module instead
  lib/pigeon/fcm.ex:167: Pigeon.FCM.start_connection/1

warning: Supervisor.Spec.worker/3 is deprecated. Use the new child specifications outlined in the Supervisor module instead
  lib/pigeon/apns.ex:128: Pigeon.APNS.start_connection/1

warning: Supervisor.Spec.worker/3 is deprecated. Use the new child specifications outlined in the Supervisor module instead
  lib/pigeon/adm.ex:159: Pigeon.ADM.start_connection/1

warning: Supervisor.Spec.supervisor/2 is deprecated. Use the new child specifications outlined in the Supervisor module instead
  lib/pigeon.ex:38: Pigeon.task_supervisors/0

warning: Supervisor.Spec.worker/3 is deprecated. Use the new child specifications outlined in the Supervisor module instead
Found at 5 locations:
  lib/pigeon.ex:34: Pigeon.apns_token_agent/0
  lib/pigeon.ex:58: Pigeon.worker/1
  lib/pigeon.ex:62: Pigeon.worker/1
  lib/pigeon.ex:85: Pigeon.workers_for/3
  lib/pigeon.ex:104: Pigeon.start_connection/1

I'm wondering if there is any workaround to these deprecation warnings or if we need to care about them at all?

Expected behavior

Pigeon would compile successfully and work with Elixir 1.12.

@mattpolzin
Copy link

This appears to be fixed in the v2 release candidates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants