Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated Node install script when building Docker image #1926

Open
6 of 7 tasks
CodeHex opened this issue Sep 14, 2023 · 2 comments 路 May be fixed by #1927
Open
6 of 7 tasks

Deprecated Node install script when building Docker image #1926

CodeHex opened this issue Sep 14, 2023 · 2 comments 路 May be fixed by #1927

Comments

@CodeHex
Copy link

CodeHex commented Sep 14, 2023 •
edited

Description of the issue 馃搫

Running the line
curl -fsSL https://deb.nodesource.com/setup_20.x in the Dockerfile comes up with a script deprecation warning and freezes the build for 60 secs. Looking at the contents of the scrpt, the warning says

This script, located at ${bold}https://deb.nodesource.com/setup_X${normal}, used to
  install Node.js is deprecated now and will eventually be made inactive.

  Please visit the NodeSource ${bold}distributions${normal} Github and follow the
  instructions to migrate your repo.
  ${underline}${green}${bold}https://github.com/nodesource/distributions${normal}

  The ${bold}NodeSource${normal} Node.js Linux distributions GitHub repository contains
  information about which versions of Node.js and which Linux distributions
  are supported and how to install it.
  ${underline}${green}${bold}https://github.com/nodesource/distributions${normal}


                          ${underline}${bold}${yellow}SCRIPT DEPRECATION WARNING${normal}
"

        echo
        echo "${cyan}${bold}TO AVOID THIS WAIT MIGRATE THE SCRIPT${normal}"
        echo "Continuing in 60 seconds (press Ctrl-C to abort) ..."
        echo
        sleep 60

Steps to fix 馃洜

Replace using the script with the updated commands described in the nodesource repo readme.

To do 馃搵

  • Claim this issue (comment below, or assign yourself if you are part of the codebar org)
  • Fork and clone the repository
  • Update the relevant files. Follow the steps to fix section in this issue.
  • Commit your changes as one commit. Use the title of this issue as your commit message
  • Submit a pull request
  • Mention this issue in the PR description by including it's number
  • Have your pull request reviewed & merged by a codebar team member
@CodeHex
Copy link
Author

CodeHex commented Sep 14, 2023

Hi 馃憢, I'm happy to have a crack at fixing this if its ok for me to work on it

@asideofcode-dev
Copy link
Contributor

@CodeHex Thanks for creating the issue. It's a recent deprecation.

Please go ahead. Happy to review the work

@CodeHex CodeHex linked a pull request Sep 14, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace deprecated script and install Node directly from nodesource CodeHex/planner
2 participants
@CodeHex @asideofcode-dev