Replace deprecated script and install Node directly from nodesource #1927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeHex
changed the title
|
When I tested this, I had to use the changes in PR #1900, as I'm working on an M1 Mac. It got through the install steps fine, but someone might want to double check it on a different machine |
I'm glad you used them. Good to get some independent confirmation that they work. |
👍 Yeah thanks, I did get a couple of test failures but running the website seems fine |
akarsh
reviewed
May 2, 2024
| RUN curl -fsSL https://deb.nodesource.com/setup_20.x | bash - | ||
| # Instructions for installing node from nodesource can be found here: | ||
| # https://github.com/nodesource/distributions | ||
| RUN set -ex; \ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing Node from nodesource scripts has been very recently deprecated (and sleeps the build for 60s). This replaces the script with installing the signed debian repo directly using the instructions provided here.
Fixes #1926