Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Past events on events page only shows workshops and should show all past events #1641

Open
7 tasks
KimberleyCook opened this issue Oct 4, 2021 · 7 comments
Open
7 tasks

Comments

@KimberleyCook
Copy link
Contributor

Description of the issue 📄

The "Past Events" section on events page only shows workshops and should show all past events - including "Events", "Meetings" and "Workshops"

Screenshots 📷

Steps to fix 🛠

To do 📋

  • Claim this issue (comment below, or assign yourself if you are part of the codebar org)
  • Fork and clone the repository
  • Update the relevant files. Follow the steps to fix section in this issue.
  • Commit your changes as one commit. Use the title of this issue as your commit message
  • Submit a pull request
  • Mention this issue in the PR description by including it's number
  • Have your pull request reviewed & merged by a codebar team member
@gnclmorais
Copy link
Contributor

To be honest, I don’t understand how this can be… I wrote a test for it, I looked into the code, and everything seems to work as expected.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Feb 11, 2022
@github-actions
Copy link

Closing as stale.

@matyikriszta
Copy link
Contributor

matyikriszta commented Apr 12, 2022

I think this is still worth investigating so reopening the issue. @gnclmorais is right, this does work locally for me (I can see both the Event and Meeting event types in the past events list). I'm going to so some digging in the production data to see if I can pinpoint an issue. Could it be that we simply do not have a Meeting or Event in the list of the past 40 events (the code takes the last 40 past Workshops, Meetings and Events, chucks them all in an array, sorts the array by the date_and_time column, reverses the array and returns the first 40 of this collated array)?

@KimberleyCook could you re-create this issue with a very recently run Event?

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions
Copy link

github-actions bot commented Feb 1, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants