Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Symmetric tensor diffusivity #64

Open
AlexSkillen opened this issue Oct 7, 2020 · 3 comments
Open

Bug: Symmetric tensor diffusivity #64

AlexSkillen opened this issue Oct 7, 2020 · 3 comments

Comments

@AlexSkillen
Copy link

The combination of turb_model->iturb = CS_TURB_NONE; and iturt(iscalt) = 10 (i.e. GGDH) leads to a segfault. I would expect the code to ignore iturt for laminar flow so the user can simply change one parameter when switching on the turbulence model. IMO, we should at least throw a warning that the settings are incompatible, rather than segfault.

It seems the issue stems from cpltur.f90 where a test for GGDH leads to an assumption of a symmetric tensor diffusivity for the thermal variable, when in reality the diffusivity is a scalar (my settings have diffusivity as variable in space and time, if it makes a difference).

@YvanFournier
Copy link
Contributor

Hello,

In which version(s) do you observe this ?

@AlexSkillen
Copy link
Author

6.x (tested 6.0 and 6.2). I've not been able to test the trunk yet. It also seems to be in 5.0

@YvanFournier
Copy link
Contributor

OK, I'll check with the turbulence developers which way (warning, silent fix, ...) they prefer to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants