Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If the robot performs a pure rotational movement that takes long, it aborts #6

Open
airballking opened this issue Mar 26, 2019 · 1 comment

Comments

@airballking
Copy link
Contributor

airballking commented Mar 26, 2019

Due to this line only considering translational velocity:

double velocity = sqrt(vx_ * vx_+ vy_ * vy_);

@airballking
Copy link
Contributor Author

As discussed with @amaldo in person, the suggested fix seems to be: (1) expose separate thresholds for instantaneous linear velocity and instantaneous rotational velocity as ROS parameters, and (2) extend the check for stopping the robot to use a conjunction of both tests.

Optionally, users should be informed about the reason for aborting the action. Either by calling ROS_ERROR or by sending a message via diagnostics. Probably, ROS_ERROR is more appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant