Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Tests make assumptions about local git config #235

Open
stephenc opened this issue Oct 27, 2022 · 1 comment
Open

[BUG] Tests make assumptions about local git config #235

stephenc opened this issue Oct 27, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@stephenc
Copy link
Contributor

Describe the bug
The tests assume that the default git branch for new repositories is called master and that git is not configured to sign all commits. As a result if you try to run the tests in an environment that is using main as the default branch for newly created repos and/or you try to run the tests where Git is configured to sign all commits, the tests fail.

To Reproduce
Steps to reproduce the behavior:

  1. Edit ~/.gitconfig and add
[init]
    defaultBranch = main
[user]
    ...
    signingkey = ....

Whereby you change the default branch and add a signingkey to the user

  1. Run the tests

Expected behavior
A clear and concise description of what you expected to happen.

The tests should pass

Additional context
Add any other context about the problem here.

@stephenc stephenc added the bug Something isn't working label Oct 27, 2022
@stephenc
Copy link
Contributor Author

I think this just requires the appropriate use if git init -b master in a couple of places as well as either adding --no-gpg-sign to the git commit commands in the tests or setting the local user config consistently as is done in helper's git_init

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants