Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get the parser out of the public API #394

Open
epage opened this issue Mar 16, 2020 · 1 comment
Open

Get the parser out of the public API #394

epage opened this issue Mar 16, 2020 · 1 comment
Labels
api-break enhancement Improve the expected

Comments

@epage
Copy link
Member

epage commented Mar 16, 2020

We have a thing wrapper around pest that is exposed in liquids API

  • The bridge creates extra work
  • We are limited in evolving the bridge's API

Ideally the parser would not be exposed at all. To do this, we'd need parser details taken out of APIs that need to parse, like tag and block parser traits.

@epage epage added enhancement Improve the expected api-break labels Mar 16, 2020
@epage
Copy link
Member Author

epage commented Mar 16, 2020

My thought for how to handle this is to allow "partial parsing". The tag/block parsing trait gets passed a &str and returns the &str from where it left off. It can then implement the parser however it wants.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-break enhancement Improve the expected
Projects
None yet
Development

No branches or pull requests

1 participant