Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unhelpful warnings during cobalt convert-jekyll #9

Open
kevinw opened this issue Feb 27, 2018 · 3 comments
Open

unhelpful warnings during cobalt convert-jekyll #9

kevinw opened this issue Feb 27, 2018 · 3 comments

Comments

@kevinw
Copy link

kevinw commented Feb 27, 2018

At the very least, these warnings should probably have filenames and line numbers:

>cobalt convert-jekyll --source Docs --destination DocsCobalt
[warn]   unsupported file extension
[warn]   sub directory parsing is not supported yet
[warn]   unsupported file extension
[warn]   unsupported file extension
[warn]   unsupported file extension
[warn]   unsupported file extension
[warn]   unsupported file extension
[warn]   unsupported file extension
[warn]   sub directory parsing is not supported yet
[warn]   sub directory parsing is not supported yet
[warn]   unsupported file extension
[warn]   unsupported file extension
[warn]   unsupported file extension
[warn]   sub directory parsing is not supported yet
[warn]   sub directory parsing is not supported yet
[warn]   sub directory parsing is not supported yet
[warn]   sub directory parsing is not supported yet
@epage
Copy link
Member

epage commented Feb 27, 2018

There is a lot more we need to do for jekyll support (see #276) but yeah, these warnings really do not help people figure out how to act on them.

@epage
Copy link
Member

epage commented Feb 27, 2018

@Geobert can probably speak more to it, but what is probably going on

  • unsupported file extension: The conversion is only prcoessing template files and not assets
  • sub directory parsing is not supported yet: The conversion only supports processing a single directory, so its warning about skipped sub-directories.

We want to improve both of those. They are covered in the above referenced issue. Hope this helps to allow you to at least make progress for now.

@Geobert
Copy link
Contributor

Geobert commented Feb 27, 2018

Yeah sorry about this feature, it was my first contribution on the project and it's a code I'm not really proud of. I'll try to add more details on these warnings but @epage is right: only md files are supported and only on one level of directory.

Event today, this feature is not really helpfull: the layout field does not complete with .liquid for instance, producing unusable files by cobalt.
And many more stuff I think…

@epage: assign this one to me please :)

@epage epage transferred this issue from cobalt-org/cobalt.rs Nov 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants