tc-env-lookup-value: suggest type constructors #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On variable lookup miss, existing suggestion code has no effect because it looks at the two places just checked. Instead check the environment to see if the var names a type, meaning, maybe the user was looking for a type constructor.
stylewarning
approved these changes
Apr 29, 2024
eliaslfox
requested changes
Apr 29, 2024
| @@ -4,6 +4,7 @@ | |||
| #:coalton-impl/typechecker/base | |||
| #:coalton-impl/typechecker/parse-type) | |||
| (:local-nicknames | |||
| (#:a #:alexandria) | |||
There was a problem hiding this comment.
i'll accept the PLN
(#:the-library-of-alexandria #:alexandria)
however. send tweet
There was a problem hiding this comment.
As a compromise, it could be referred to via the Mongolian vowel separator jbouwman#2
| "Look up a type binding of VAR-NAME in type checker environment ENV." | ||
| (gethash var-name (tc-env-ty-table env))) | ||
|
|
||
| (defun lookup-var (env var-name) |
There was a problem hiding this comment.
Don't define this function.
| @@ -47,57 +48,59 @@ | |||
|
|
|||
| (tc:qualified-ty-type (tc:fresh-inst (setf (gethash name (tc-env-ty-table env)) (tc:to-scheme (tc:make-variable)))))) | |||
|
|
|||
| (defun lookup-var-type (env var-name) | |||
There was a problem hiding this comment.
Don't define this function.
| (push (apply #'format nil fmt-string fmt-args) suggestions))) | ||
|
|
||
| ;; If the symbol names a type, user may have intended to use a type constructor | ||
| (a:when-let ((type (tc:lookup-type (tc-env-env env) var-name :no-error t))) |
| (defun tc-env-suggest-value (env var-name) | ||
| "If value lookup failed, generate suggestions for what to do, if anything." | ||
| (let ((suggestions nil)) | ||
| (flet ((suggest (fmt-string &rest fmt-args) |
There was a problem hiding this comment.
Just write this inline.
| "Look up a variable binding of VAR-NAME in type checker environment ENV." | ||
| (tc:lookup-value-type (tc-env-env env) var-name :no-error t)) | ||
|
|
||
| (defun tc-env-suggest-value (env var-name) |
There was a problem hiding this comment.
Add type annotations to this function.
| ;; including checking other places in the environment and | ||
| ;; catching simple spelling errors. | ||
|
|
||
| ) |
| (defun tc-env-lookup-value (env var file) | ||
| "Lookup a variable named VAR in ENV." | ||
| "Lookup the value of a variable named VAR in ENV." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On variable lookup miss, existing suggestion code has no effect because it looks at the two places just checked. Instead check the environment to see if the var names a type, meaning, maybe the user was looking for a type constructor.
Closes #1095