Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.coafile: Add YAMLLintBear #186

Closed
wants to merge 2 commits into from
Closed

Conversation

lherman-cs
Copy link

Add YAMLLintBear to .coafile and
fix .travis.yml issues raised by coala

Closes #183

.travis.yml Outdated
rm bears/haskell/GhcModBear.py tests/haskell/GhcModBearTest.py;
rm -r bears/verilog tests/verilog/;
rm
bears/c_languages/CSharpLintBear.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add indentation for arguments , so that it is easy to see where the next command starts.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, sure.

@lherman-cs
Copy link
Author

Can someone help me to pass ci/dockercloud? I don't know what breaks it. Thanks

@lherman-cs lherman-cs closed this Jun 22, 2017
@lherman-cs lherman-cs reopened this Jun 22, 2017
@lherman-cs
Copy link
Author

I'm so sorry. I miss clicked the button. Instead of "Comment," I clicked "Close and comment"

@jayvdb
Copy link
Member

jayvdb commented Jun 29, 2017

@lherman-cs , can you rebase this patch (see the guides in our dev docs for how-to)

.travis.yml Outdated
set -e -x;
/work/pytest.sh;
/work/vcs.sh;
=======

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntax error: could not find expected ':'

YAMLLintBear, severity MAJOR, section yml.

@jayvdb
Copy link
Member

jayvdb commented Jul 4, 2017

Hi @lherman-cs , to rebase properly, you should archive your current branch , to a name like old-pr-186, then checkout master and sync your master with upstream master, then recreate the branch hotfix/#183 and put your one commit on that branch. Then repush.

@gitmate-bot
Copy link

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

2 similar comments
@gitmate-bot
Copy link

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

@gitmate-bot
Copy link

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Add YAMLLintBear to .coafile and
fix .travis.yml issues raised by coala

Closes coala#183
@lherman-cs
Copy link
Author

Thanks, @jayvdb. I've fixed all the issues you mentioned before.

Copy link
Member

@anshumanv anshumanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check comments.


[yml]
bears = YAMLLintBear
files = *.yml, hooks/*.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a new line at file end.

Copy link
Member

@aashutoshrathi aashutoshrathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add LineLengthBear too.
and better change [yml] to [YAML]

Copy link
Member

@Monal5031 Monal5031 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lherman-cs Please make changes as requested by other reviewers.
Also, squash your commits into one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Check repository for .yml files using YAMLLintBear
7 participants