Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for note markers in the whole sheet #89

Open
matt-dray opened this issue Sep 16, 2022 · 1 comment
Open

Check for note markers in the whole sheet #89

matt-dray opened this issue Sep 16, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@matt-dray
Copy link
Collaborator

See best-practice-and-impact/gptables#197.

I had interpreted the accessibility checklist (point 3) to mean:

column_heading var_1 Notes
Inside shop x
Street x
Outside shop x
In public entertainment x [note 1] applies to cell XX

It's possible in {a11ytables} to add a note anywhere, however; there's no proper 'note placing system'.

There is some logic that warns the user if notes are expected but not found (based on the content of the notes sheet), but it won't fire if the note is placed in a 'data cell' (it only checks for '[note x]' in the headers, or for a specific 'Notes' column).

I may need to update the note-existence check for user convenience.

(I personally don't want note markers in my data, but a11ytables can get this note-checking update at relatively little cost.)

@matt-dray matt-dray added the enhancement New feature or request label Sep 16, 2022
@matt-dray matt-dray changed the title Check for note markers in the whole table Check for note markers in the whole sheet Dec 28, 2023
@matt-dray
Copy link
Collaborator Author

updated the title to 'whole sheet' from 'whole table', reflecting the possibility of notes in pre-table meta content as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant