Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should hunktool.py learn how to extract version information? #51

Open
cmsj opened this issue Aug 3, 2016 · 1 comment
Open

Should hunktool.py learn how to extract version information? #51

cmsj opened this issue Aug 3, 2016 · 1 comment

Comments

@cmsj
Copy link
Contributor

cmsj commented Aug 3, 2016

I've found it very useful to be able to recursively scan archives/directories/binaries with hunktool, but my purpose was to gather lots of version information.

To do this I hacked together a quick fork of hunktool.py which uses Python's re module to search for the $VER: cookie. It's not complete because it ignores part of the version string, but it was sufficient for my needs.

Is there any interest in having this polished up and made part of hunktool? (or a separate tool specifically for printing version strings).

You can see my hackfork at: https://github.com/cmsj/amitools/blob/e94cc3dacd8cc1a987101d34be23425a117210ba/amitools/tools/version_hunktool.py

@cnvogelg
Copy link
Owner

cnvogelg commented Aug 6, 2016

I really like the new version command and I'd be interested in a pull request from you.
I'd suggest to extend the existing amitools/util/VertTag.py and add something like a find_all() to retrieve all tags. Then the hunktool only needs to call the functions from the amitools package. That's the approach I take for the command line tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants