Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Fields for Projects - Annual Reviews #3037

Closed
amye opened this issue Feb 13, 2023 · 10 comments
Closed

New Fields for Projects - Annual Reviews #3037

amye opened this issue Feb 13, 2023 · 10 comments
Assignees

Comments

@amye
Copy link
Contributor

amye commented Feb 13, 2023

We'd like a way to track annual reviews for projects in the Landscape.

This should be only for CNCF hosted projects. Right now, only sandbox projects have annual reviews, but we might want this to extend to all projects.

This should depend on the month that they were accepted in the year.
(1) Currently, we have pull requests into the TOC repo for annual reviews. I think that's a fine way to be able to handle this, because we want to make sure that projects are submitting. We should key this off 'PR submitted' and add it to the landscape.
(2) We want a way for the project to mark when they've submitted their annual review - 'YYYY-MM-DD' is fine
(3) Is there a good way to have historical annual reviews without causing metadata collision? We'd like to track since 2020.
(4) Finally, if a project is more than three months past their acceptance month into CNCF, we'd want a way to flag that annual review as being late. (If a project was accepted in January 2022 and we have no data by April 2023, we'd like to highlight that!)

Can we get this in by like.. Feb 27th?

@caniszczyk
Copy link
Contributor

caniszczyk commented Feb 13, 2023

I guess we need two new fields but they can be tossed in the extra category imho

annual_review:
annual_review_date:

I don't think we need any engineering work from @AndreyKozlov1984 on this @amye unless we want to make UI changes to say a card if the last annual review date was more than a year old ;)

@caniszczyk
Copy link
Contributor

See this PR as an example @amye: #3037

@amye
Copy link
Contributor Author

amye commented Feb 13, 2023

#3039 should break, it's one example of multiple reviews.

@amye
Copy link
Contributor Author

amye commented Feb 13, 2023

I guess we need two new fields but they can be tossed in the extra category imho

annual_review: annual_review_date:

I don't think we need any engineering work from @AndreyKozlov1984 on this @amye unless we want to make UI changes to say a card if the last annual review date was more than a year old ;)

If it's a sandbox project and it hasn't had an annual review more than three months past acceptance month (so 'accepted' + 3 months), we should flag it.
I'll get the data added and we'll see where that lands!

@caniszczyk
Copy link
Contributor

The only thing that needs to be fixed is in the UI so annual_review_url displays a hyperlink to where things are vs a date

cc: @AndreyKozlov1984

@amye
Copy link
Contributor Author

amye commented Feb 13, 2023

#3040 adds data from the TOC repo

@tegioz
Copy link
Contributor

tegioz commented Apr 11, 2024

Hi @amye 👋

Is this still relevant for landscape v2? We could display them like we do for the security audits, but was asking because of this: cncf/toc#1181

@amye
Copy link
Contributor Author

amye commented Apr 11, 2024

Hi @amye 👋

Is this still relevant for landscape v2? We could display them like we do for the security audits, but was asking because of this: cncf/toc#1181

Discuss with @jeefy!

@tegioz
Copy link
Contributor

tegioz commented Apr 30, 2024

Hi @amye 👋

Is this still relevant for landscape v2? We could display them like we do for the security audits, but was asking because of this: cncf/toc#1181

Discuss with @jeefy!

Any thoughts @jeefy? 😉

@tegioz
Copy link
Contributor

tegioz commented May 14, 2024

Will close this one for now given that annual reviews seem to be going away (cncf/toc#1181). Please feel free to reopen if needed 🙂

@tegioz tegioz closed this as not planned Won't fix, can't repro, duplicate, stale May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants