Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make breadcrumbs multi-level, semantic #43

Closed
thetwopct opened this issue Feb 14, 2024 · 1 comment
Closed

Make breadcrumbs multi-level, semantic #43

thetwopct opened this issue Feb 14, 2024 · 1 comment
Assignees
@thetwopct

Comments

@thetwopct
Copy link
Collaborator

Switch out and style current breadcrumb to be multi-level, semantic and add aria labels.

<nav class="" aria-label="breadcrumbs">
    <ol class="">
        {{- range .Ancestors.Reverse }}
      <li class="breadcrumb">
        <a href="{{ .RelPermalink }}">{{ if .IsHome }}{{ i18n "home" }}{{ else }}{{ .Title }}{{ end }}</a>
      </li>
      <span class="" aria-hidden="true">»</span>
      {{- end }}
    </ol>
  </nav>
@thetwopct thetwopct self-assigned this Feb 14, 2024
thetwopct added a commit that referenced this issue May 21, 2024
@thetwopct
#43 Improve breadcrumbs
5150947 
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>

Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@thetwopct thetwopct mentioned this issue May 21, 2024
Merged
@thetwopct
Copy link
Collaborator Author

Improved and released in https://github.com/cncf/dot-org-hugo-theme/releases/tag/v0.1.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thetwopct thetwopct

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thetwopct