Fixed problem with file delete in CleanupService #350
Conversation
|
Pushed a fix, had to move the delete code into the main task because of logger usage. Built a docker container and tested on local machine. If this PR is accepted, would appreciate a new updated official socializer container. |
|
I added a new commit that takes into account a target disk utilization when deleting posts. This does not have to be used, if a target disk utilization is specified as < 0 then only post age is used. I realized that by adding this, can use a large postAge (like 3 days or so) and not worry about filling up the disk even if a lot of traffic generators as the posts will be deleted on as needed basis. I have built the docker container and tested this locally.
|
|
I have converted to draft as I am having problems computing disk utilization correctly on Docker containers. I am investigating. |
|
Now ready for review. |
This fixes #349 as per the discussion in the issue.
I believed old posts were being deleted but the count was not being reported correctly as the count reporting from the query was done after the posts were deleted. I tested this theory on a simple test using sample code from:
https://learn.microsoft.com/en-us/dotnet/api/system.linq.queryable.where?view=net-8.0
and it checked out.
I have tested the
deleteFilesfunction on sample data.