Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sparkline doesn't reflect trend very well #1111

Open
ryantibs opened this issue Jan 4, 2022 · 4 comments
Open

Sparkline doesn't reflect trend very well #1111

ryantibs opened this issue Jan 4, 2022 · 4 comments

Comments

@ryantibs
Copy link
Member

ryantibs commented Jan 4, 2022

It seems to me like our dashboard's sparklines sometimes don't reflect the underlying trends very well. See the example two screenshots from mobile below (sorry for the full-width, it looks like GitHub does that by default), though to be clear I don't think it's a mobile/desktop issue.

Covid cases appear to be blowing up on the first time series plot, but the sparkline doesn't really reflect that in the indicator table. This isn't a very specific request (sorry), but is there anything we can to get the sparklines to reflect the trend better?

IMG_0977
IMG_0978

@ryantibs
Copy link
Member Author

ryantibs commented Jan 4, 2022

To be clear, this is low priority compared to the other v3.1 items. If we can't find a good solution with relatively little effort, then it's fine: we can just move on without it.

@sgratzl
Copy link
Member

sgratzl commented Jan 5, 2022

so far the sparklines have no fixed y-axis limits and adapt to the data going from the minimal value to the maximal value within the four week period. It is the most generic way that works for all signals and changes without manual intervention.

@sgratzl sgratzl added the feedback required The issue is requiring is waiting for some external help label Jan 5, 2022
@sgratzl sgratzl removed their assignment Jan 5, 2022
@ryantibs
Copy link
Member Author

ryantibs commented Jan 5, 2022

Right, I understand that's generally the way it works. I was just hoping there might be some generic tweaks to help it show trends better. For example, tweak the aspect ratio so that it's a bit taller than it is now. But as I said, this is pretty low priority, so if there's not a relatively easy fix, then we should move on.

@ryantibs
Copy link
Member Author

ryantibs commented Jan 6, 2022

Removing this from consideration for v3.1 since I don't get the impression that Sam sees it as an easy fix.

@ryantibs ryantibs removed v3.1 feedback required The issue is requiring is waiting for some external help labels Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants