Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clear_lastminute_nas will erase too much data as written for chng #103

Open
dsweber2 opened this issue Feb 28, 2024 · 0 comments
Open

clear_lastminute_nas will erase too much data as written for chng #103

dsweber2 opened this issue Feb 28, 2024 · 0 comments

Comments

@dsweber2
Copy link
Contributor

Currently, clear_lastminute_nas will remove any row which has any NA's in it whatsoever. With multiple signals, this can mean removing rows with real data (as an example, see 11-29-24, for which 10-02-24 is the last day with data). Before using chng, we will need another scheme to handle differently missing data. Ideas:

  • locf NA's in non-outcome signals. This is not a great idea, as lags likely become meaningless.
  • do the equivalent of extend_ahead but for lags (e.g. if the last observation for chng is 30 days behind, adjust the lags of c(0,7,14) to c(30,37,44).
  • ?

@brookslogan may have other thoughts I forgot about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant