Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epix_slide_ref_time_values_default misbehaves on datetimes #447

Open
3 tasks
brookslogan opened this issue May 3, 2024 · 0 comments
Open
3 tasks

epix_slide_ref_time_values_default misbehaves on datetimes #447

brookslogan opened this issue May 3, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@brookslogan
Copy link
Contributor

  • For dates converted into POSIXct's, diff, used by guess_period, outputs in terms of days, but + and full_seq adding on that period do it in terms of seconds, yielding a ton of bogus ref time values.
  • We should check that the full_seq results actually contain all of the original time_values in case there is numeric messiness that can go on... or perhaps use tol = 0. In former approach, probably want a temporary to hold the sorted unique time values.
  • (We should also export guess_period and rename ref_time_values args to time_values.)
@brookslogan brookslogan added the bug Something isn't working label May 3, 2024
@brookslogan brookslogan self-assigned this May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant