Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change horizon in step_growth_rate() and arx_class_args_list() #324

Open
rachlobay opened this issue Apr 27, 2024 · 1 comment
Open

Change horizon in step_growth_rate() and arx_class_args_list() #324

rachlobay opened this issue Apr 27, 2024 · 1 comment

Comments

@rachlobay
Copy link
Contributor

rachlobay commented Apr 27, 2024

We sometimes use horizon interchangeably with ahead and so perhaps we should change the name of it in step_growth_rate() and arx_class_args_list() (and anywhere else it gets used in such a way in this package). Since it is passed to the h argument of epiprocess::growth_rate(), then maybe the easiest thing is to just refer to it as h?

@brookslogan
Copy link
Contributor

Since horizon is used by the Hubverse for "reference date"-relative targeting (which are something like a label for (the end of) some time interval containing the forecast submission deadline), perhaps we want to stay away from that term and h for these, and standardize around ahead, at least for max time_value-relative stuff?

(The reasoning behind these reference dates includes allowing some flexibility for forecast deadlines to change without changing horizon-labeling and without having people have to be aware of when to pretend forecasts were submitted on a different date. E.g., the time intervals used were epiweeks, so changing deadline from say Tue -> Wed would not impact the reference date.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants