Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider switching all geodataframe tests to use gpd instead of pd asserts #619

Open
krivard opened this issue Mar 28, 2023 · 0 comments
Open

Comments

@krivard
Copy link
Contributor

krivard commented Mar 28, 2023

#617 switches from pd.testing.assert_frame_equal to gpd.testing.assert_geodataframe_equal when comparing data frames with polygons and multipolygons in test__join_county_geo_df. This was necessary due to a (probable) change in representation that the pandas assert couldn't interpret properly.

For consistency, we may want to change the remaining applicable pandas asserts in Python-packages/covidcast-py/tests/test_plotting.py to geopandas asserts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant