Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tidyselect usage in evalcast #611

Open
brookslogan opened this issue Jan 13, 2023 · 0 comments
Open

Update tidyselect usage in evalcast #611

brookslogan opened this issue Jan 13, 2023 · 0 comments
Labels
evalcast package good first issue Good for newcomers

Comments

@brookslogan
Copy link
Collaborator

brookslogan commented Jan 13, 2023 •
edited

Update tidyselect usage in evalcast, as was done for covidcast. The check warnings state the changes that should be made.

Relevant check warnings (use `devtools::test()` locally to get up-to-date line numbers): 
── Warning ('test-evaluate_predictions.R:41'): evaluate_covid_predictions evaluates against downloaded data ──
Use of .data in tidyselect expressions was deprecated in tidyselect 1.2.0.
ℹ Please use `"forecast_date"` instead of `.data$forecast_date`
Backtrace:
  1. evalcast::evaluate_covid_predictions(pcard, geo_type = "state")
       at test-evaluate_predictions.R:41:4
  2. evalcast:::get_covidcast_data(...)
  7. dplyr:::select.data.frame(predictions_cards, .data$forecast_date)
 10. tidyselect::eval_select(expr(c(...)), .data)
 11. tidyselect:::eval_select_impl(...)
 15. tidyselect:::vars_select_eval(...)
 16. tidyselect:::walk_data_tree(expr, data_mask, context_mask)
 17. tidyselect:::eval_c(expr, data_mask, context_mask)
 18. tidyselect:::reduce_sels(node, data_mask, context_mask, init = init)
 19. tidyselect:::walk_data_tree(new, data_mask, context_mask)
 20. tidyselect:::expr_kind(expr, context_mask, error_call)
 21. tidyselect:::call_kind(expr, context_mask, error_call)
── Warning ('test-evaluate_predictions.R:41'): evaluate_covid_predictions evaluates against downloaded data ──
Use of .data in tidyselect expressions was deprecated in tidyselect 1.2.0.
ℹ Please use `"geo_value"` instead of `.data$geo_value`
Backtrace:
  1. evalcast::evaluate_covid_predictions(pcard, geo_type = "state")
       at test-evaluate_predictions.R:41:4
  2. evalcast:::get_covidcast_data(...)
  7. dplyr:::select.data.frame(predictions_cards, .data$geo_value)
 10. tidyselect::eval_select(expr(c(...)), .data)
 11. tidyselect:::eval_select_impl(...)
 15. tidyselect:::vars_select_eval(...)
 16. tidyselect:::walk_data_tree(expr, data_mask, context_mask)
 17. tidyselect:::eval_c(expr, data_mask, context_mask)
 18. tidyselect:::reduce_sels(node, data_mask, context_mask, init = init)
 19. tidyselect:::walk_data_tree(new, data_mask, context_mask)
 20. tidyselect:::expr_kind(expr, context_mask, error_call)
 21. tidyselect:::call_kind(expr, context_mask, error_call)
── Warning ('test-evaluate_predictions.R:41'): evaluate_covid_predictions evaluates against downloaded data ──
Use of .data in tidyselect expressions was deprecated in tidyselect 1.2.0.
ℹ Please use `"start"` instead of `.data$start`
Backtrace:
  1. evalcast::evaluate_covid_predictions(pcard, geo_type = "state")
       at test-evaluate_predictions.R:41:4
 11. dplyr:::rename.data.frame(., start_day = .data$start, end_day = .data$end)
 12. tidyselect::eval_rename(expr(c(...)), .data)
 13. tidyselect:::rename_impl(...)
 14. tidyselect:::eval_select_impl(...)
 18. tidyselect:::vars_select_eval(...)
 19. tidyselect:::walk_data_tree(expr, data_mask, context_mask)
 20. tidyselect:::eval_c(expr, data_mask, context_mask)
 21. tidyselect:::reduce_sels(node, data_mask, context_mask, init = init)
 22. tidyselect:::walk_data_tree(new, data_mask, context_mask)
 23. tidyselect:::expr_kind(expr, context_mask, error_call)
 24. tidyselect:::call_kind(expr, context_mask, error_call)
── Warning ('test-evaluate_predictions.R:41'): evaluate_covid_predictions evaluates against downloaded data ──
Use of .data in tidyselect expressions was deprecated in tidyselect 1.2.0.
ℹ Please use `"end"` instead of `.data$end`
Backtrace:
  1. evalcast::evaluate_covid_predictions(pcard, geo_type = "state")
       at test-evaluate_predictions.R:41:4
 11. dplyr:::rename.data.frame(., start_day = .data$start, end_day = .data$end)
 12. tidyselect::eval_rename(expr(c(...)), .data)
 13. tidyselect:::rename_impl(...)
 14. tidyselect:::eval_select_impl(...)
 18. tidyselect:::vars_select_eval(...)
 19. tidyselect:::walk_data_tree(expr, data_mask, context_mask)
 20. tidyselect:::eval_c(expr, data_mask, context_mask)
 21. tidyselect:::reduce_sels(node, data_mask, context_mask, init = init)
 22. tidyselect:::walk_data_tree(new, data_mask, context_mask)
 23. tidyselect:::expr_kind(expr, context_mask, error_call)
 24. tidyselect:::call_kind(expr, context_mask, error_call)
── Warning ('test-evaluate_predictions.R:41'): evaluate_covid_predictions evaluates against downloaded data ──
Use of .data in tidyselect expressions was deprecated in tidyselect 1.2.0.
ℹ Please use `"quantile"` instead of `.data$quantile`
Backtrace:
  1. evalcast::evaluate_covid_predictions(pcard, geo_type = "state")
       at test-evaluate_predictions.R:41:4
  6. dplyr:::relocate.data.frame(., .data$quantile:.data$value, .after = .data$geo_value)
  7. tidyselect::eval_select(expr(c(...)), .data)
  8. tidyselect:::eval_select_impl(...)
 12. tidyselect:::vars_select_eval(...)
 13. tidyselect:::walk_data_tree(expr, data_mask, context_mask)
 14. tidyselect:::eval_c(expr, data_mask, context_mask)
 15. tidyselect:::reduce_sels(node, data_mask, context_mask, init = init)
 16. tidyselect:::walk_data_tree(new, data_mask, context_mask)
 17. tidyselect:::eval_colon(expr, data_mask, context_mask)
 18. tidyselect:::walk_data_tree(...)
 19. tidyselect:::expr_kind(expr, context_mask, error_call)
 20. tidyselect:::call_kind(expr, context_mask, error_call)
── Warning ('test-evaluate_predictions.R:41'): evaluate_covid_predictions evaluates against downloaded data ──
Use of .data in tidyselect expressions was deprecated in tidyselect 1.2.0.
ℹ Please use `"value"` instead of `.data$value`
Backtrace:
  1. evalcast::evaluate_covid_predictions(pcard, geo_type = "state")
       at test-evaluate_predictions.R:41:4
  6. dplyr:::relocate.data.frame(., .data$quantile:.data$value, .after = .data$geo_value)
  7. tidyselect::eval_select(expr(c(...)), .data)
  8. tidyselect:::eval_select_impl(...)
 12. tidyselect:::vars_select_eval(...)
 13. tidyselect:::walk_data_tree(expr, data_mask, context_mask)
 14. tidyselect:::eval_c(expr, data_mask, context_mask)
 15. tidyselect:::reduce_sels(node, data_mask, context_mask, init = init)
 16. tidyselect:::walk_data_tree(new, data_mask, context_mask)
 17. tidyselect:::eval_colon(expr, data_mask, context_mask)
 18. tidyselect:::walk_data_tree(...)
 19. tidyselect:::expr_kind(expr, context_mask, error_call)
 20. tidyselect:::call_kind(expr, context_mask, error_call)
── Warning ('test-evaluate_predictions.R:41'): evaluate_covid_predictions evaluates against downloaded data ──
Use of .data in tidyselect expressions was deprecated in tidyselect 1.2.0.
ℹ Please use `"ahead"` instead of `.data$ahead`
Backtrace:
  1. evalcast::evaluate_covid_predictions(pcard, geo_type = "state")
       at test-evaluate_predictions.R:41:4
  4. dplyr:::relocate.data.frame(...)
  5. tidyselect::eval_select(expr(c(...)), .data)
  6. tidyselect:::eval_select_impl(...)
 10. tidyselect:::vars_select_eval(...)
 11. tidyselect:::walk_data_tree(expr, data_mask, context_mask)
 12. tidyselect:::eval_c(expr, data_mask, context_mask)
 13. tidyselect:::reduce_sels(node, data_mask, context_mask, init = init)
 14. tidyselect:::walk_data_tree(new, data_mask, context_mask)
 15. tidyselect:::expr_kind(expr, context_mask, error_call)
 16. tidyselect:::call_kind(expr, context_mask, error_call)
── Warning ('test-evaluate_predictions.R:41'): evaluate_covid_predictions evaluates against downloaded data ──
Use of .data in tidyselect expressions was deprecated in tidyselect 1.2.0.
ℹ Please use `"forecaster"` instead of `.data$forecaster`
Backtrace:
  1. evalcast::evaluate_covid_predictions(pcard, geo_type = "state")
       at test-evaluate_predictions.R:41:4
  4. dplyr:::relocate.data.frame(...)
  5. tidyselect::eval_select(expr(c(...)), .data)
  6. tidyselect:::eval_select_impl(...)
 10. tidyselect:::vars_select_eval(...)
 11. tidyselect:::walk_data_tree(expr, data_mask, context_mask)
 12. tidyselect:::eval_c(expr, data_mask, context_mask)
 13. tidyselect:::reduce_sels(node, data_mask, context_mask, init = init)
 14. tidyselect:::walk_data_tree(new, data_mask, context_mask)
 15. tidyselect:::expr_kind(expr, context_mask, error_call)
 16. tidyselect:::call_kind(expr, context_mask, error_call)
── Warning ('test-evaluate_predictions.R:41'): evaluate_covid_predictions evaluates against downloaded data ──
Use of .data in tidyselect expressions was deprecated in tidyselect 1.2.0.
ℹ Please use `"data_source"` instead of `.data$data_source`
Backtrace:
  1. evalcast::evaluate_covid_predictions(pcard, geo_type = "state")
       at test-evaluate_predictions.R:41:4
  4. dplyr:::relocate.data.frame(...)
  5. tidyselect::eval_select(expr(c(...)), .data)
  6. tidyselect:::eval_select_impl(...)
 10. tidyselect:::vars_select_eval(...)
 11. tidyselect:::walk_data_tree(expr, data_mask, context_mask)
 12. tidyselect:::eval_c(expr, data_mask, context_mask)
 13. tidyselect:::reduce_sels(node, data_mask, context_mask, init = init)
 14. tidyselect:::walk_data_tree(new, data_mask, context_mask)
 15. tidyselect:::expr_kind(expr, context_mask, error_call)
 16. tidyselect:::call_kind(expr, context_mask, error_call)
── Warning ('test-evaluate_predictions.R:41'): evaluate_covid_predictions evaluates against downloaded data ──
Use of .data in tidyselect expressions was deprecated in tidyselect 1.2.0.
ℹ Please use `"signal"` instead of `.data$signal`
Backtrace:
  1. evalcast::evaluate_covid_predictions(pcard, geo_type = "state")
       at test-evaluate_predictions.R:41:4
  4. dplyr:::relocate.data.frame(...)
  5. tidyselect::eval_select(expr(c(...)), .data)
  6. tidyselect:::eval_select_impl(...)
 10. tidyselect:::vars_select_eval(...)
 11. tidyselect:::walk_data_tree(expr, data_mask, context_mask)
 12. tidyselect:::eval_c(expr, data_mask, context_mask)
 13. tidyselect:::reduce_sels(node, data_mask, context_mask, init = init)
 14. tidyselect:::walk_data_tree(new, data_mask, context_mask)
 15. tidyselect:::expr_kind(expr, context_mask, error_call)
 16. tidyselect:::call_kind(expr, context_mask, error_call)
── Warning ('test-evaluate_predictions.R:41'): evaluate_covid_predictions evaluates against downloaded data ──
Use of .data in tidyselect expressions was deprecated in tidyselect 1.2.0.
ℹ Please use `"target_end_date"` instead of `.data$target_end_date`
Backtrace:
  1. evalcast::evaluate_covid_predictions(pcard, geo_type = "state")
       at test-evaluate_predictions.R:41:4
  4. dplyr:::relocate.data.frame(...)
  5. tidyselect::eval_select(expr(c(...)), .data)
  6. tidyselect:::eval_select_impl(...)
 10. tidyselect:::vars_select_eval(...)
 11. tidyselect:::walk_data_tree(expr, data_mask, context_mask)
 12. tidyselect:::eval_c(expr, data_mask, context_mask)
 13. tidyselect:::reduce_sels(node, data_mask, context_mask, init = init)
 14. tidyselect:::walk_data_tree(new, data_mask, context_mask)
 15. tidyselect:::expr_kind(expr, context_mask, error_call)
 16. tidyselect:::call_kind(expr, context_mask, error_call)
── Warning ('test-evaluate_predictions.R:41'): evaluate_covid_predictions evaluates against downloaded data ──
Use of .data in tidyselect expressions was deprecated in tidyselect 1.2.0.
ℹ Please use `"incidence_period"` instead of `.data$incidence_period`
Backtrace:
  1. evalcast::evaluate_covid_predictions(pcard, geo_type = "state")
       at test-evaluate_predictions.R:41:4
  4. dplyr:::relocate.data.frame(...)
  5. tidyselect::eval_select(expr(c(...)), .data)
  6. tidyselect:::eval_select_impl(...)
 10. tidyselect:::vars_select_eval(...)
 11. tidyselect:::walk_data_tree(expr, data_mask, context_mask)
 12. tidyselect:::eval_c(expr, data_mask, context_mask)
 13. tidyselect:::reduce_sels(node, data_mask, context_mask, init = init)
 14. tidyselect:::walk_data_tree(new, data_mask, context_mask)
 15. tidyselect:::expr_kind(expr, context_mask, error_call)
 16. tidyselect:::call_kind(expr, context_mask, error_call)
── Warning ('test-evaluate_predictions.R:41'): evaluate_covid_predictions evaluates against downloaded data ──
Use of .data in tidyselect expressions was deprecated in tidyselect 1.2.0.
ℹ Please use `"actual"` instead of `.data$actual`
Backtrace:
  1. evalcast::evaluate_covid_predictions(pcard, geo_type = "state")
       at test-evaluate_predictions.R:41:4
  4. dplyr:::relocate.data.frame(...)
  5. tidyselect::eval_select(expr(c(...)), .data)
  6. tidyselect:::eval_select_impl(...)
 10. tidyselect:::vars_select_eval(...)
 11. tidyselect:::walk_data_tree(expr, data_mask, context_mask)
 12. tidyselect:::eval_c(expr, data_mask, context_mask)
 13. tidyselect:::reduce_sels(node, data_mask, context_mask, init = init)
 14. tidyselect:::walk_data_tree(new, data_mask, context_mask)
 15. tidyselect:::expr_kind(expr, context_mask, error_call)
 16. tidyselect:::call_kind(expr, context_mask, error_call)
── Warning ('test-plot_coverage.R:42'): plot_coverage default plotting args type all ──
Use of .data in tidyselect expressions was deprecated in tidyselect 1.2.0.
ℹ Please use `"name"` instead of `.data$name`
Backtrace:
  1. vdiffr::expect_doppelganger(...)
       at test-plot_coverage.R:42:4
  9. dplyr:::select.data.frame(., .data$name)
 12. tidyselect::eval_select(expr(c(...)), .data)
 13. tidyselect:::eval_select_impl(...)
 17. tidyselect:::vars_select_eval(...)
 18. tidyselect:::walk_data_tree(expr, data_mask, context_mask)
 19. tidyselect:::eval_c(expr, data_mask, context_mask)
 20. tidyselect:::reduce_sels(node, data_mask, context_mask, init = init)
 21. tidyselect:::walk_data_tree(new, data_mask, context_mask)
 22. tidyselect:::expr_kind(expr, context_mask, error_call)
 23. tidyselect:::call_kind(expr, context_mask, error_call)
── Warning ('test-plot_coverage.R:42'): plot_coverage default plotting args type all ──
Use of .data in tidyselect expressions was deprecated in tidyselect 1.2.0.
ℹ Please use `"is_above"` instead of `.data$is_above`
Backtrace:
  1. vdiffr::expect_doppelganger(...)
       at test-plot_coverage.R:42:4
 10. dplyr:::select.data.frame(...)
 13. tidyselect::eval_select(expr(c(...)), .data)
 14. tidyselect:::eval_select_impl(...)
 18. tidyselect:::vars_select_eval(...)
 19. tidyselect:::walk_data_tree(expr, data_mask, context_mask)
 20. tidyselect:::eval_c(expr, data_mask, context_mask)
 21. tidyselect:::reduce_sels(node, data_mask, context_mask, init = init)
 22. tidyselect:::walk_data_tree(new, data_mask, context_mask)
 23. tidyselect:::expr_kind(expr, context_mask, error_call)
 24. tidyselect:::call_kind(expr, context_mask, error_call)
── Warning ('test-plot_coverage.R:42'): plot_coverage default plotting args type all ──
Use of .data in tidyselect expressions was deprecated in tidyselect 1.2.0.
ℹ Please use `"is_below"` instead of `.data$is_below`
Backtrace:
  1. vdiffr::expect_doppelganger(...)
       at test-plot_coverage.R:42:4
 10. dplyr:::select.data.frame(...)
 13. tidyselect::eval_select(expr(c(...)), .data)
 14. tidyselect:::eval_select_impl(...)
 18. tidyselect:::vars_select_eval(...)
 19. tidyselect:::walk_data_tree(expr, data_mask, context_mask)
 20. tidyselect:::eval_c(expr, data_mask, context_mask)
 21. tidyselect:::reduce_sels(node, data_mask, context_mask, init = init)
 22. tidyselect:::walk_data_tree(new, data_mask, context_mask)
 23. tidyselect:::expr_kind(expr, context_mask, error_call)
 24. tidyselect:::call_kind(expr, context_mask, error_call)
── Warning ('test-plot_coverage.R:42'): plot_coverage default plotting args type all ──
Use of .data in tidyselect expressions was deprecated in tidyselect 1.2.0.
ℹ Please use `"is_covered"` instead of `.data$is_covered`
Backtrace:
  1. vdiffr::expect_doppelganger(...)
       at test-plot_coverage.R:42:4
 10. dplyr:::select.data.frame(...)
 13. tidyselect::eval_select(expr(c(...)), .data)
 14. tidyselect:::eval_select_impl(...)
 18. tidyselect:::vars_select_eval(...)
 19. tidyselect:::walk_data_tree(expr, data_mask, context_mask)
 20. tidyselect:::eval_c(expr, data_mask, context_mask)
 21. tidyselect:::reduce_sels(node, data_mask, context_mask, init = init)
 22. tidyselect:::walk_data_tree(new, data_mask, context_mask)
 23. tidyselect:::expr_kind(expr, context_mask, error_call)
 24. tidyselect:::call_kind(expr, context_mask, error_call)
── Warning ('test-plot_coverage.R:42'): plot_coverage default plotting args type all ──
Use of .data in tidyselect expressions was deprecated in tidyselect 1.2.0.
ℹ Please use `"nominal_prob"` instead of `.data$nominal_prob`
Backtrace:
  1. vdiffr::expect_doppelganger(...)
       at test-plot_coverage.R:42:4
 10. dplyr:::select.data.frame(...)
 13. tidyselect::eval_select(expr(c(...)), .data)
 14. tidyselect:::eval_select_impl(...)
 18. tidyselect:::vars_select_eval(...)
 19. tidyselect:::walk_data_tree(expr, data_mask, context_mask)
 20. tidyselect:::eval_c(expr, data_mask, context_mask)
 21. tidyselect:::reduce_sels(node, data_mask, context_mask, init = init)
 22. tidyselect:::walk_data_tree(new, data_mask, context_mask)
 23. tidyselect:::expr_kind(expr, context_mask, error_call)
 24. tidyselect:::call_kind(expr, context_mask, error_call)
── Warning ('test-plot_coverage.R:42'): plot_coverage default plotting args type all ──
Adding new file snapshot: 'tests/testthat/_snaps/plot-default-args-type-all.svg'
── Warning ('test-plot_coverage.R:58'): plot_coverage custom facets type all ───
Adding new file snapshot: 'tests/testthat/_snaps/plot-custom-facets-one-type-all.svg'
── Warning ('test-plot_coverage.R:72'): plot_coverage custom facets type all ───
Adding new file snapshot: 'tests/testthat/_snaps/plot-custom-facets-two-type-all.svg'
── Warning ('test-predictions_processing.R:83'): desired prediction card columns are kept and reordered ──
Use of .data in tidyselect expressions was deprecated in tidyselect 1.2.0.
ℹ Please use `"location"` instead of `.data$location`
Backtrace:
  1. evalcast:::select_pcard_cols(preds_in)
       at test-predictions_processing.R:83:2
  4. dplyr:::select.data.frame(...)
  7. tidyselect::eval_select(expr(c(...)), .data)
  8. tidyselect:::eval_select_impl(...)
 12. tidyselect:::vars_select_eval(...)
 13. tidyselect:::walk_data_tree(expr, data_mask, context_mask)
 14. tidyselect:::eval_c(expr, data_mask, context_mask)
 15. tidyselect:::reduce_sels(node, data_mask, context_mask, init = init)
 16. tidyselect:::walk_data_tree(new, data_mask, context_mask)
 17. tidyselect:::expr_kind(expr, context_mask, error_call)
 18. tidyselect:::call_kind(expr, context_mask, error_call)
── Warning ('test-scale_by_forecaster.R:16'): scale_by_forecaster works on score_cards ──
Using an external vector in selections was deprecated in tidyselect 1.1.0.
ℹ Please use `all_of()` or `any_of()` instead.
  # Was:
  data %>% select(var)

  # Now:
  data %>% select(all_of(var))

See <https://tidyselect.r-lib.org/reference/faq-external-vector.html>.
Backtrace:
  1. evalcast::scale_by_forecaster(score_card, c("ae", "wis"), "f2")
       at test-scale_by_forecaster.R:16:4
 14. tidyr:::pivot_wider.data.frame(...)
 15. tidyr::build_wider_spec(...)
 16. tidyselect::eval_select(enquo(values_from), data)
 17. tidyselect:::eval_select_impl(...)
 21. tidyselect:::vars_select_eval(...)
 22. tidyselect:::walk_data_tree(expr, data_mask, context_mask)
 23. tidyselect:::eval_sym(expr, data_mask, context_mask)

Probably not time-sensitive: the tidyselect changelog does not mention that these will turn into errors soon.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
evalcast package good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brookslogan