Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make predict_time_value make sense when recent data is missing in create_train_and_predict_matrices #569

Open
brookslogan opened this issue Oct 12, 2021 · 0 comments

Comments

@brookslogan
Copy link
Collaborator

brookslogan commented Oct 12, 2021

modeltools::create_train_and_predict_matrices currently assumes that the latest time_value in the input data should be predict_time_value. However, this assumption does not appear to be documented, and appears to be violated, e.g., in animalia::production_forecaster, when the latest data available for a signal is not for the forecast date. (Which is all the time for all covidcast signals that I am aware of. Moreso for sources like hhs that can regularly lag by a few days.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant