Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evalcast plot_coverage type one needs formatting cleanup #516

Open
sarah-colq opened this issue Mar 30, 2021 · 2 comments
Open

evalcast plot_coverage type one needs formatting cleanup #516

sarah-colq opened this issue Mar 30, 2021 · 2 comments

Comments

@sarah-colq
Copy link
Contributor

type one plots for coverage plots do weird formatting. They will have the forecaster as the x variable (for example), but then also facet by the forecaster, so we end up with repeated information. If you try to make sure the x variable (grps[1]) is not faceted, then it is still treated as a color variable, so you end up with different colors for the x variables.

Formatting for these plots needs to be cleaned up so that variables are not repeated across two types of aes (facets, colors, and x/y axis), and tests need to be written for the one plots.

@sarah-colq
Copy link
Contributor Author

Additionally, if as a result of this grp_processing_for_facets is no longer used, that function can be deleted, as this is the only place it is used.

@sarah-colq
Copy link
Contributor Author

To be clear, PR does not fix issue, just referencing a PR that covers the all type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant