Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated pkg_resources #1921

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Replace deprecated pkg_resources #1921

wants to merge 2 commits into from

Conversation

rzats
Copy link
Contributor

@rzats rzats commented Jan 4, 2024 •
edited

Closes #1902.

Summary:

Removes uses of setuptools' deprecated pkg_resources library - these are replaced by the importlib_resources backport. This is due to the features needed in the codebase, like accessing resources within subdirectories, only becoming available in Python 3.9+.

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

@rzats rzats requested a review from melange396 January 4, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melange396 melange396 Awaiting requested review from melange396

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

replace deprecated pkg_resources
1 participant
@rzats