Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardize indicator runs #1895

Open
melange396 opened this issue Aug 17, 2023 · 3 comments
Open

standardize indicator runs #1895

melange396 opened this issue Aug 17, 2023 · 3 comments

Comments

@melange396
Copy link
Contributor

most indicators are set (in Cronicle) to run via the delphi_utils.runner wrapper:

  • changehc
  • google_symptoms
  • claims_hosp
  • quidel_covidtest
  • even the now-defunct (and disabled in Cronicle) dsew_community_profile

those commands take the form python -m delphi_utils.runner delphi_INDICATORNAME

some others do not run that way:

  • nchs_mortality has its module run directly (python -m delphi_nchs_mortality)
  • hhs_hosp runs via a call to make run (which has seperate steps for the pipeline, validator, and archive)
  • doctor_visits mysteriously runs a script (that doesnt seem to be in github) w/ a non-standard user on a non-standard machine

determine whether we can and should convert them all to run within the "runner" that provides validation and archiving, among other things.

@melange396
Copy link
Contributor Author

additionally, a number of README.md files (located alongside indicator code in this repo) show outdated instructions, and should be updated to include the runner.

@nmdefries
Copy link
Contributor

+1 for standardization!

@melange396
Copy link
Contributor Author

another point of note:
the "runner" uses the archiver_from_params() utility to automatically create an archive differ as appropriate from the job's given "params", but since it does not use the "runner", nchs_mortality explicitly creates its own S3ArchiveDiffer in two places (1, 2).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants