Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert requests mocks to use requests_mock library instead #1863

Open
krivard opened this issue Jun 23, 2023 · 1 comment
Open

Convert requests mocks to use requests_mock library instead #1863

krivard opened this issue Jun 23, 2023 · 1 comment
Labels
chore good first issue good independent project refactor Long-term projects to revise existing machinery

Comments

@krivard
Copy link
Contributor

krivard commented Jun 23, 2023 •
edited

#1864 adds a test to validator that mocks out an HTTP request using the requests_mock library. That tests file also includes a mechanism to manually mock out HTTP requests using a custom class. We should replace usage of the custom class with usage of requests_mock instead.
@krivard krivard added refactor Long-term projects to revise existing machinery good first issue chore good independent project labels Jun 23, 2023
@dshemetov
Copy link
Contributor

There is also responses, which seems a little more popular. A tiny discussion between the maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore good first issue good independent project refactor Long-term projects to revise existing machinery
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@krivard @dshemetov