Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Humans can't buckle to vehicle gunner seats #6246

Closed
3 tasks done
Doubleumc opened this issue May 6, 2024 · 0 comments · Fixed by #6247
Closed
3 tasks done

Humans can't buckle to vehicle gunner seats #6246

Doubleumc opened this issue May 6, 2024 · 0 comments · Fixed by #6247
Labels
Bug Admin events aren't bugs

Comments

@Doubleumc
Copy link
Contributor

Testmerges

N/A

Round ID

No response

Description of the bug

A human attempting to buckle to a vehicle's gunner seat (click-drag) causes the user to move to the seat's tile but does not buckle and does not grant the exterior vision or control over the hardpoints.

Believe the issue is here:

cmss13/code/modules/vehicles/interior/interactable/seats.dm

Line 111 in ff95ae9

if(!HAS_TRAIT(user, TRAIT_OPPOSABLE_THUMBS))

Humans do not inherently have TRAIT_OPPOSABLE_THUMBS, it is assumed either through a ishuman() check or a IsAdvancedToolUser() check.

What's the difference with what should have happened?

Humans should be able to buckle to the gunner seat, allowing control over the hardpoints.

How do we reproduce this bug?

  1. Spawn vehicle with gunner seat (APC, tank)
  2. Spawn & inhabit a human that should be able to control gunnery (vehicle crewman)
  3. Click-drag to buckle self to gunner seat

Issue Bingo
@Doubleumc Doubleumc added the Bug Admin events aren't bugs label May 6, 2024
@Doubleumc Doubleumc mentioned this issue May 6, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue May 15, 2024
@Doubleumc
Fixes humans unable to use vehicle gunner seat (#6247)
6fdd3cd 
# About the pull request

Fixes #6246

<!-- Remove this text and explain what the purpose of your PR is.

Mention if you have tested your changes. If you changed a map, make sure
you used the mapmerge tool.
If this is an Issue Correction, you can type "Fixes Issue #169420" to
link the PR to the corresponding Issue number #169420.

Remember: something that is self-evident to you might not be to others.
Explain your rationale fully, even if you feel it goes without saying.
-->

# Explain why it's good for the game

Vehicle gunnery is meant to be used by humans.
# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog
:cl:
fix: humans can use vehicle gunner seats again
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Admin events aren't bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes humans unable to use vehicle gunner seat Doubleumc/cmss13
1 participant
@Doubleumc