Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There are multiple information leaks in cms-dev/cms #1160

Open
niuzhi opened this issue Aug 14, 2020 · 3 comments
Open

There are multiple information leaks in cms-dev/cms #1160

niuzhi opened this issue Aug 14, 2020 · 3 comments
Milestone

Comments

@niuzhi
Copy link

niuzhi commented Aug 14, 2020

1.file: cms/cmscontrib/AddAdmin.py
function:add_admin
Log information disclosure username and password

image

@NhatMinh0208
Copy link

Uhmmmmmm...... that's normal. It's where the cmsAddAdmin script reminds you of the login info for the admin account you just created. That does not constitute a leak.

@MaGaroo
Copy link
Contributor

MaGaroo commented Jul 17, 2021

I'm not sure about it but is it really normal to log plain text passwords?

In this special case I think it's ok since logger.info is being used as a normal stdout print statement.
Also there must be a way to let the user know the randomly generated password.

@niuzhi Do you have a more secure way in mind to do this?

@wil93 wil93 added the bug label Nov 27, 2022
@wil93
Copy link
Member

wil93 commented Nov 27, 2022

I agree that we could at least log the password only when it gets randomly generated (i.e. the password is None case) and skip showing it when it's provided (i.e. when we call cmsAddAdmin ... -p thepassword)

@wil93 wil93 added this to the P1 milestone Nov 27, 2022
@wil93 wil93 added the cli label Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants