Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dependency tslib #192

Open
hjellek opened this issue Sep 11, 2023 · 1 comment
Open

Missing dependency tslib #192

hjellek opened this issue Sep 11, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@hjellek
Copy link

hjellek commented Sep 11, 2023

Please describe the bug you are seeing

Installing docusaurus with pnpm (which have stricter defaults to hoisting) causes this plugin to be unable to import tslib, as it is not declared as a dependency.

Docusaurus itself correctly specifies this dependency: https://github.com/facebook/docusaurus/blob/3f09fb11a12950c9419ae38fb1b7a04ec1ec8e66/packages/docusaurus/package.json#L98

How can we best reproduce the bug?

No response

Which version of Docusaurus and @cmfcmf/docusaurus-search-local are you using?

Docusaurus 2.4.1
docusaurus-local-search 1.1.0

Which Node.js version are you using?

No response

Which theme are you using?

Yes, I am using @docusaurus/theme-classic

How does your plugin config look like?

No response

Additional context

No response

@hjellek hjellek added the bug Something isn't working label Sep 11, 2023
hjellek added a commit to hjellek/docusaurus-search-local that referenced this issue Sep 11, 2023
hjellek added a commit to hjellek/docusaurus-search-local that referenced this issue Sep 11, 2023
hjellek added a commit to hjellek/docusaurus-search-local that referenced this issue Sep 11, 2023
hjellek added a commit to hjellek/docusaurus-search-local that referenced this issue Sep 11, 2023
hjellek added a commit to hjellek/docusaurus-search-local that referenced this issue Sep 11, 2023
hjellek added a commit to hjellek/docusaurus-search-local that referenced this issue Sep 11, 2023
@mkska
Copy link

mkska commented May 2, 2024

@docusaurus/utils-validation is missing too from the deps.

The overrides part is there because I'm using the search-local pkg with docusaurus v3 (via).

I use this as a workaround in my package.json with pnpm (pnpm docs packageExtensions):

"pnpm": {
    "packageExtensions": {
      "@cmfcmf/docusaurus-search-local": {
        "dependencies": {
          "tslib": "*",
          "@docusaurus/utils-validation": "*"
        }
      }
    },
    "overrides": {
      "@docusaurus/core": "^3.2.1"
    }
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants