Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix multi controller for sync resource #802

Merged
merged 2 commits into from May 20, 2024
Merged

Conversation

zhenkuang
Copy link
Contributor

What type of PR is this?

Bug fixed

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #801

Special notes for your reviewer:

@zhenkuang zhenkuang requested a review from a team as a code owner April 24, 2024 12:30
@zhenkuang zhenkuang requested a review from yiwei-C April 24, 2024 12:30
Signed-off-by: zhenkuang <zhenkuang@126.com>
@dixudx dixudx added the kind/bug Something isn't working label Apr 25, 2024
@dixudx dixudx added this to the v0.17.0 milestone Apr 25, 2024
Copy link
Member

@dixudx dixudx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Please optimize the logic. We're getting close.

pkg/agent/deployer/generic/generic.go Show resolved Hide resolved
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.93%. Comparing base (e2ffa5f) to head (4e1973d).
Report is 147 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #802      +/-   ##
==========================================
+ Coverage   13.60%   13.93%   +0.32%     
==========================================
  Files          66       77      +11     
  Lines        7492     9052    +1560     
==========================================
+ Hits         1019     1261     +242     
- Misses       6391     7694    +1303     
- Partials       82       97      +15     
Flag Coverage Δ
unittests 13.93% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dixudx dixudx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work.

@dixudx dixudx merged commit 432defd into clusternet:main May 20, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sub cluster initiated multiple controllers for processing the same resource
2 participants