for dividing scheduling, manifest changes should not directly trigger the updates of base objects

[dixudx]

What happened:

clusternet/pkg/controllermanager/deployer/deployer.go

Lines 984 to 1014 in 44064bf

	func (deployer *Deployer) handleManifest(manifestCopy *appsapi.Manifest) error {
	klog.V(5).Infof("handle Manifest %s", klog.KObj(manifestCopy))
	if manifestCopy.DeletionTimestamp != nil {
	if err := deployer.protectManifestFeed(manifestCopy); err != nil {
	return err
	}
	// remove finalizers
	manifestCopy.Finalizers = utils.RemoveString(manifestCopy.Finalizers, known.AppFinalizer)
	manifestCopy.Finalizers = utils.RemoveString(manifestCopy.Finalizers, known.FeedProtectionFinalizer)
	_, err := deployer.clusternetClient.AppsV1alpha1().Manifests(manifestCopy.Namespace).Update(context.TODO(), manifestCopy, metav1.UpdateOptions{})
	if err != nil {
	if apierrors.IsNotFound(err) {
	return nil
	}
	klog.WarningDepth(4,
	fmt.Sprintf("failed to remove finalizers from Manifest %s: %v", klog.KObj(manifestCopy), err))
	}
	return err
	}
	// find all referred Base UIDs
	var baseUIDs []string
	for key, val := range manifestCopy.Labels {
	if val == baseKind.Kind {
	baseUIDs = append(baseUIDs, key)
	}
	}
	return deployer.resyncBase(baseUIDs...)
	}

What you expected to happen:

Only for Replication scheduling strategy, we could directly trigger the updates of base objects.
For Dividing scheduling strategy, we can only update/trigger base objects after the scheduling finishes. xref #688 and #772

It seems resyncBase are only invoked by the updates of manifests and helmcharts. Maybe we could add a check on subscription scheduling strategy inside func resyncBase.

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

• Clusternet version:
  • Clusternet-agent version (user clusternet-agent --version=json):
  • Clusternet-hub version (user clusternet-hub --version=json):
• Kubernetes version (use kubectl version):
• Cloud provider or hardware configuration:
• OS (e.g: cat /etc/os-release):
• Kernel (e.g. uname -a):
• Others:

[dixudx]

@abstractmj will work on this.