Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase code coverage #729

Open
nashtsai opened this issue Aug 17, 2023 · 4 comments
Open

Increase code coverage #729

nashtsai opened this issue Aug 17, 2023 · 4 comments
Assignees
@ayushgml
Labels
kind/feature New feature or request

Comments

@nashtsai
Copy link

nashtsai commented Aug 17, 2023 •
edited

What would you like to be added:

Increase code coverage.

Why is this needed:

Currently it's only 13%, and I would evaluate it as an alpha quality project, and not even consider adopting it.
@nashtsai nashtsai added the kind/feature New feature or request label Aug 17, 2023
@nashtsai
Copy link
Author

nashtsai commented Aug 17, 2023 •
edited

After take a closer look at https://app.codecov.io/gh/clusternet/clusternet , the contents doesn't look right to me, I believe you need to fix GH action workflow to upload correct coverage report including correct director structure.

@dixudx
Copy link
Member

dixudx commented Aug 17, 2023

@nashtsai Some test cases could be added to help improve the code coverage.

@ayushgml
Copy link

@dixudx Can you assign me this issue?

@ayushgml
Copy link

@dixudx I am unable to reproduce working on this issue on my MacOS. Any suggestions which route I can take?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ayushgml ayushgml

Labels
kind/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nashtsai @dixudx @ayushgml