You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've followed the instructions in "Contribution to Clustorio" to the point that it asks to test a potential contribution via pnpm run test. Running that command gives 1 failing test:
1) Integration of host/src/server
_getVersion()
should get a version from factorio's changelog.txt:
AssertionError [ERR_ASSERTION]: Detected version 'null' does not followed the format x.y.z
at Context.<anonymous> (test/integration/server.js:19:12)
Debugging the issue it seems to be that the cluster setup step node packages/create --dev downloads the factorio headless server in the folder factorio/[version number], while the test expects it to be in factorio. Removing the factorio headless server entirely results in 21 failing tests, without any clear indication to the cause.
For clarity for starting developers it would be useful if:
The getVersion test works after following the install instructions.
The testing framework would give a clear error when it could not find a factorio headless server, rather than letting tests fail that depend on it.
The text was updated successfully, but these errors were encountered:
I've followed the instructions in "Contribution to Clustorio" to the point that it asks to test a potential contribution via
pnpm run test
. Running that command gives 1 failing test:Debugging the issue it seems to be that the cluster setup step
node packages/create --dev
downloads the factorio headless server in the folderfactorio/[version number]
, while the test expects it to be infactorio
. Removing the factorio headless server entirely results in 21 failing tests, without any clear indication to the cause.For clarity for starting developers it would be useful if:
The text was updated successfully, but these errors were encountered: