Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fail after following "Contributing to Clusterio" instructions #540

Open
Laar opened this issue Jan 13, 2024 · 0 comments
Open

Test fail after following "Contributing to Clusterio" instructions #540

Laar opened this issue Jan 13, 2024 · 0 comments

Comments

@Laar
Copy link
Contributor

Laar commented Jan 13, 2024

I've followed the instructions in "Contribution to Clustorio" to the point that it asks to test a potential contribution via pnpm run test. Running that command gives 1 failing test:

  1) Integration of host/src/server
       _getVersion()
         should get a version from factorio's changelog.txt:
     AssertionError [ERR_ASSERTION]: Detected version 'null' does not followed the format x.y.z
      at Context.<anonymous> (test/integration/server.js:19:12)

Debugging the issue it seems to be that the cluster setup step node packages/create --dev downloads the factorio headless server in the folder factorio/[version number], while the test expects it to be in factorio. Removing the factorio headless server entirely results in 21 failing tests, without any clear indication to the cause.

For clarity for starting developers it would be useful if:

  • The getVersion test works after following the install instructions.
  • The testing framework would give a clear error when it could not find a factorio headless server, rather than letting tests fail that depend on it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant