Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inject serial object into NumatoUsbGpio constructor #42

Open
3 tasks
clssn opened this issue Mar 10, 2024 · 0 comments
Open
3 tasks

Inject serial object into NumatoUsbGpio constructor #42

clssn opened this issue Mar 10, 2024 · 0 comments
Labels
breaking-change Has to be announced and reflected in version
Milestone
Software Design

Comments

@clssn
Copy link
Owner

clssn commented Mar 10, 2024 •
edited

  • Remove instantiation of Serial object from constructor
  • Add convenience factory as classmethod from_device
  • Adapt test fixture and test implementations
@clssn clssn added this to the Software Design milestone Mar 10, 2024
@clssn clssn added the breaking-change Has to be announced and reflected in version label Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change Has to be announced and reflected in version
Projects
None yet
Milestone
Software Design
Development

No branches or pull requests
1 participant
@clssn