Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GAT in volo-grpc SendEntryMessage #107

Open
LYF1999 opened this issue Dec 6, 2022 · 2 comments
Open

Use GAT in volo-grpc SendEntryMessage #107

LYF1999 opened this issue Dec 6, 2022 · 2 comments
Assignees
Labels
A-volo-grpc This issue concerns the `volo-grpc` crate. C-enhancement This is a PR that adds a new feature or fixes a bug.

Comments

@LYF1999
Copy link
Member

LYF1999 commented Dec 6, 2022

Feature Request

Crates

Motivation

The definition of SendEntryMessage can be better with GAT

pub trait SendEntryMessage {
    fn into_body(
        self,
        compression_config: Option<CompressionEncoding>,
    ) -> crate::BoxStream<'static, Result<Bytes, crate::Status>>;
}

with GAT

pub trait SendEntryMessage {
    type Body: Stream<Item = Result<Bytes, crate::Status>> + Send
    fn into_body(
        self,
        compression_config: Option<CompressionEncoding>,
    ) -> Self::Body;
}
@LYF1999 LYF1999 added C-enhancement This is a PR that adds a new feature or fixes a bug. A-volo-grpc This issue concerns the `volo-grpc` crate. labels Dec 6, 2022
@CrazyCollin
Copy link

I want have a try, can you assign it to me?

@PureWhiteWu
Copy link
Member

Of course you can, just try!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-volo-grpc This issue concerns the `volo-grpc` crate. C-enhancement This is a PR that adds a new feature or fixes a bug.
Development

No branches or pull requests

3 participants