feat: Take into account number of databases in an instance #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instances configured with <1000 PUs only support 10 DBs per 100 PUs so clamp the minimum size to the relevant number of PUs Fixes cloudspannerecosystem#286
davidcueva
reviewed
May 13, 2024
Review comments
henrybell
requested changes
May 15, 2024
| @@ -25,6 +25,7 @@ const AutoscalerUnits = { | |||
| * currentSize: number, | |||
| * regional: boolean, | |||
| * currentNodes: number, | |||
| * numDatabases: number, | |||
There was a problem hiding this comment.
Worth considering currentDatabases, currentNumDatabases, or similar, to be consistent with the other metadata fields that may change over time?
| @@ -304,6 +314,7 @@ async function getSpannerMetadata(projectId, spannerInstanceId, units) { | |||
| regional: !!metadata['config']?.split('/')?.pop()?.startsWith('regional'), | |||
| // DEPRECATED | |||
| currentNodes: assertDefined(metadata['nodeCount']), | |||
| numDatabases: numDatabases, | |||
There was a problem hiding this comment.
For clarity perhaps reformat these few lines or move the comment to show that it is only the currentNodes field that is deprecated (despite the single-line comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instances configured with <1000 PUs only support 10 DBs per 100 PUs so clamp the minimum size to the relevant number of PUs
Fixes #286