Fix issue with subnet_ids list variable being put into a list in the aws_db_subnet_group resource and issue with records in dns_host_name module #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jross-ai
changed the title
jross-ai
changed the title
jross-ai
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11
Currently, the subnet_ids variable is defined as a list in the variables.tf. This variable is then getting set to a list which is causing the aws_db_subnet_group to fail to create because the subnet_ids are being passed as a list of lists, not a list of strings. This PR should resolve this issue and close issue #11
Also upgrading the version on the dns_host_name module to fix an issue with that resource