Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting testing images are failing #151

Closed
sxd opened this issue May 14, 2022 · 3 comments
Closed

Deleting testing images are failing #151

sxd opened this issue May 14, 2022 · 3 comments
Labels
bug 🐛 Something isn't working
Milestone
2022-Q2

Comments

@sxd
Copy link
Member

sxd commented May 14, 2022

The workflow that deletes -testing images are failing like here: https://github.com/cloudnative-pg/cloudnative-pg/runs/6430524440?check_suite_focus=true
On the other side, this workflow should run scheduled and on workflow dispatch, but not on push
@sxd sxd added this to the 2022-Q2 milestone May 14, 2022
@sxd sxd added the bug 🐛 Something isn't working label May 14, 2022
@mnencia
Copy link
Member

mnencia commented May 16, 2022

The job is failing because it has no access to the GitHub PAT secret. You are correct that the workflow should not run on PR, which will solve the issue. I would also change the workflow not to require the secret and to use the standard GitHub token and specify the necessary permission from the workflow YAML.

@mnencia
Copy link
Member

mnencia commented May 16, 2022

Unfortunately, the GITHUB_TOKEN is not enough until snok/container-retention-policy#27 is solved (by GitHub)

@mnencia
Copy link
Member

mnencia commented May 16, 2022

Closed by #152

@mnencia mnencia closed this as completed May 16, 2022
mnencia pushed a commit that referenced this issue Dec 29, 2022
@dependabot
chore(deps): Bump azure/login from 1.4.5 to 1.4.6 (#151)
57d0d70 
Bumps [azure/login](https://github.com/azure/login) from 1.4.5 to 1.4.6.
- [Release notes](https://github.com/azure/login/releases)
- [Commits](Azure/login@v1.4.5...v1.4.6)

---
updated-dependencies:
- dependency-name: azure/login
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something isn't working
Projects
CloudNativePG operator development
Archived in project
Milestone
2022-Q2
Development

No branches or pull requests
2 participants
@mnencia @sxd