Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP TRACE Method still returning request information #2185

Open
tack-sap opened this issue Jan 26, 2023 · 2 comments
Open

HTTP TRACE Method still returning request information #2185

tack-sap opened this issue Jan 26, 2023 · 2 comments
Labels
unscheduled waiting-4-pr Pull-Request is wanted in order to proceed

Comments

@tack-sap
Copy link
Contributor

What version of UAA are you running?

{"version":"76.5.0"} deployed, but also on the latest develop branch

How are you deploying the UAA?

I am deploying the UAA locally only using gradlew, but it is reproducible in our bosh deployment

What did you do?

This is a followup to #2125 and #2129

When calling any endpoint of the UAA with an HTTP Trace method, I do not get the desired result back from the UAA.

What did you expect to see? What goal are you trying to achieve with the UAA?

I was expecting to get a 405 error and either no content or an 405 error page.

What did you see instead?

I get a 405 response code, but the Body of the response is still returning the complete HTTP request that was send to the UAA - including e.g. all headers that were added in between.
As there is no need to have this information returned by the UAA and the details could contain information that should not be shown to the caller (e.g. internal IPs or other information that was added for the UAA), the UAA should not return this information to the caller.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/184324049

The labels on this github issue will be updated when the story is started.

@strehle
Copy link
Member

strehle commented Jan 26, 2023

@tack-sap agree with you, can you please open a PR ?

@strehle strehle added the waiting-4-pr Pull-Request is wanted in order to proceed label Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unscheduled waiting-4-pr Pull-Request is wanted in order to proceed
Projects
Development

No branches or pull requests

3 participants