Make whitespace trimming in log messages optional #506
+71
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Log Cache Syslog server trims leading and trailing whitespace in the messages. The log messages should be not changed. This change: - adds config parameter to define if the whitespace in the log messages should be trimmed or not - trims or leaves the log message untouched based on the config parameter The default behavior is to trim the log messages, so that it is compatible with the behavior up until now.
mkocher
reviewed
May 24, 2024
| @@ -151,6 +152,39 @@ var _ = Describe("Syslog", func() { | |||
| )) | |||
| }) | |||
|
|
|||
| It("doesn't trim whitespace in log messages", func() { | |||
There was a problem hiding this comment.
Should there be contexts for with and without trimming to test both cases?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Log Cache Syslog server trims leading and trailing whitespace in the messages. The log messages should be not changed.
This change:
The default behavior is to trim the log messages, so that it is compatible with the behavior up until now.
Fixes #505
Type of change
Testing performed?
Checklist:
mainbranch, or relevant version branch