Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory Calculator version #997

Open
mayrstefan opened this issue Feb 21, 2023 · 3 comments
Open

Memory Calculator version #997

mayrstefan opened this issue Feb 21, 2023 · 3 comments

Comments

@mayrstefan
Copy link
Contributor

Is there a reason the Java Buildpack is still using Memory Calculator 3.13.x instead of 4.2.x? Are those versions not compatible?

@mayrstefan
Copy link
Contributor Author

Okay, I see they use different cli parameters which is a breaking change. Are there any plans for an upgrade?

@dmikusa
Copy link
Contributor

dmikusa commented Mar 6, 2023

Yes, that is a reason.

Also, the 4.x branch was done before @pivotal-david-osullivan or I started working on the project and we have no context on the changes there. Why it was done, what advantages it has over 3.x, why did the cli flags change, etc... Since there's no context on the project anymore, we'd have to do a pretty extensive code and commit review before doing anything with it.

Is there something you are looking for that is in the 4.x branch but not in 3.x?

@mayrstefan
Copy link
Contributor Author

I was just wondering what is going here. Also I found a reference to version 4.1 when looking around the Tanzu buildpack docs: https://docs.vmware.com/en/VMware-Tanzu-Buildpacks/services/tanzu-buildpacks/GUID-release-notes-graalvm-release-notes.html. Surprisingly this is only mentioned as a dependency in old versions of the GraalsVM buildpack. For paketo buildpacks the memory calculatore now seems to be part of the runtimes via a go dependency. We can find the calculator in https://github.com/paketo-buildpacks/libjvm/tree/main/calc

Maybe @nebhale can tell us what was the reason for the changes of the memory calculator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants