jrebel 6.4.2a prevents offline build #290
Comments
|
I am facing the same issue since yesterday for Liberty build pack as well. can you confirm that removing the 6.4.2a line from cached yml is not a problem? |
|
The Zero turn around team have an invalid index file. I'll both contact them to improve it and add a fix to the buildpack that will warn and ignore on illegal values. |
Previously, version resolution with the contents of repository indexes was strict. If there was an illegal version, all resolution would stop; in other words, the buildpack would cease to function. This recently became an issue for the first time when a third-party repository added an invalid version number to their index breaking all users of the buildpack. This change updates the version resolution logic to ignore and warn on a bad version instead of failing. [#290]
|
why not change /lib/java_buildpack/util/tokenized_version.rb valid_major_minor_or_micro to use \w instead of \d for people who want to use that new version of jrebel? 154 def valid_major_minor_or_micro(major_minor_or_micro) |
|
The version number is specified and documented here. Changes to that would be a breaking change. It's up to the repositories to meet the specification rather than the specification changing to meet the repositories. |
|
makes sense. thx. |
|
Any updates on this? |
|
I've not gotten a response from JRebel about fixing their repository, but the build in |
|
Sorry this happened. We weren't aware of the restrictions on the version format. We'll update the repository as soon as possible and I'll let you know here as well. @nebhale I couldn't find your email. For future reference, so we can avoid communication black holes, how did you try to reach out? |
|
@mirkoadari I sent an email to Mark Taber which admittedly was a long shot. Your best bet is to create an account on http://cloudfoundry.slack.com and find me in #java-buildpack. If you want email, it's bhale@<Pivotal's Domain>. |
|
We've updated the repository. If there's any issues in the future, please shoot an email to support@zeroturnaround.com. That's the fastest way to get to a resolution. Sorry for the trouble everyone. |
Hi,
Jrebel 6.4.2a was released a few days ago and the buildpack is not happy about "2a":
$ bundle exec rake package OFFLINE=true
rake aborted!
Invalid micro version '2a'
Changing config/jrebel_agent.yml to 6.4.2 doesn't fix the issue. I managed to build the offline buildpack by removing the last line from build/staging/resources/cache/https%3A%2F%2Fdl.zeroturnaround.com%2Fjrebel%2Findex.yml.cached
The text was updated successfully, but these errors were encountered: