Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bypass acceptance tests for release notes #215

Open
domdom82 opened this issue Jun 22, 2021 · 3 comments
Open

bypass acceptance tests for release notes #215

domdom82 opened this issue Jun 22, 2021 · 3 comments

Comments

@domdom82
Copy link
Contributor

  • With the addition of acceptance tests, the build time got bumped significantly higher. (> 20m)
  • Acceptance tests are expensive and only make sense if there are changes to test.
  • To make a new release, we need to add release_notes.md
  • CI should skip acceptance tests if the PR contains only release_notes.md (maybe also README.md changes)
  • CI should still run tests if the PR contains other code
@peanball
Copy link
Contributor

We could add [no-ci] or some similar text to release note commits, which would not run the CI task, or rather run an abbreviated task that skips CI and marks the step successful.

@plowin
Copy link
Contributor

plowin commented Feb 8, 2023

I think rel-notes are often part of a PR including a feature.
As label is on a PR, we probably rather need to adjust it on a code-level

@peanball
Copy link
Contributor

peanball commented Feb 8, 2023

Please consider any file changes that don't affect the acceptance tests as "to be ignored". This includes the pipeline definition and support scripts for the pipeline (e.g. shipit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants