Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document abandoned features #196

Open
gcapizzi opened this issue Jul 6, 2021 · 0 comments
Open

Document abandoned features #196

gcapizzi opened this issue Jul 6, 2021 · 0 comments
Labels
docs features
Projects
Garden DEPRECATED - WG-Application-Runtime-P... DEPRECATED App Platform - Garden Con...
Milestone
Handover

Comments

@gcapizzi
Copy link
Contributor

gcapizzi commented Jul 6, 2021 •
edited

Let's (briefly) document the features we have stopped developing some time ago, but haven't removed from the codebase. These are the ones I can think of:

  • OCI mode
  • Rootless

We want this to be detailed enough to be helpful for someone who gets across these features in the codebase, but not more than that. No one will ever need to change these features, although they might want to delete them at some point!
@gcapizzi gcapizzi created this issue from a note in Garden (Scheduled) Jul 6, 2021
@gcapizzi gcapizzi added this to the Handover milestone Jul 6, 2021
@ameowlia ameowlia moved this from Blocked to Issue Inbox in DEPRECATED App Platform - Diego Oct 28, 2021
@ameowlia ameowlia removed this from Issue Inbox in DEPRECATED App Platform - Diego Oct 28, 2021
@ameowlia ameowlia moved this from Inbox to Issues - Triage Complete. Needs Fix. in DEPRECATED App Platform - Garden Containers Oct 29, 2021
winkingturtle-vmw added a commit that referenced this issue Mar 6, 2023
@winkingturtle-vmw
bump dontpanic garden garden-integration-tests garden-performance-acc…
a2ff1b9 
…eptance-tests grootfs guardian idmapper netplugin-shim

Submodule src/dontpanic ab22a1d9..f5fb3aff:
  > Merge pull request #65 from cloudfoundry/unpin-components
Submodule src/garden 0f701405..9056cc03:
  > Merge pull request #105 from cloudfoundry/unpin-components
Submodule src/garden-integration-tests d79a737e..cc6bde8b:
  > Merge pull request #68 from cloudfoundry/unpin-components
Submodule src/garden-performance-acceptance-tests 312ffa3e..a4b9e7df:
  > Merge pull request #49 from cloudfoundry/unpin-components
Submodule src/grootfs 615df9c5..29b5ed38:
  > Merge pull request #196 from cloudfoundry/unpin-components
Submodule src/guardian 04fa770d..b2e500ec:
  > Merge pull request #359 from cloudfoundry/unpin-components
Submodule src/idmapper eee5914d..e10f296e:
  > Merge pull request #65 from cloudfoundry/unpin-components
  > Bump github.com/onsi/ginkgo/v2 from 2.8.4 to 2.9.0
Submodule src/netplugin-shim a0553419..0b28ae05:
  > Merge pull request #46 from cloudfoundry/unpin-components
@winkingturtle-vmw winkingturtle-vmw mentioned this issue Dec 1, 2023
Closed
winkingturtle-vmw pushed a commit to cloudfoundry/guardian that referenced this issue Apr 19, 2024
@MarcPaquette @winkingturtle-vmw
Remove rootless functionality
4c7e9b8 
- [x] Read the [Contributing document](../blob/-/.github/CONTRIBUTING.md).

Summary
---------------
Remove rootless functionality and tests. This abondoned feature was
broken when deployed.

Context: cloudfoundry/garden-runc-release#196

Backward Compatibility
---------------
Breaking Change? **Yes**

Remove rootless functionality

Signed-off-by: Amin Jamali <amin.jamali@broadcom.com>
@winkingturtle-vmw winkingturtle-vmw mentioned this issue Apr 19, 2024
Merged
1 task
winkingturtle-vmw pushed a commit to cloudfoundry/garden-integration-tests that referenced this issue Apr 19, 2024
@MarcPaquette @winkingturtle-vmw
Remove rootless functionality
db123da 
- [x] Read the [Contributing document](../blob/-/.github/CONTRIBUTING.md).

Summary
---------------
Remove rootless functionality

Context: cloudfoundry/garden-runc-release#196

Backward Compatibility
---------------
Breaking Change? **No**

Signed-off-by: Amin Jamali <amin.jamali@broadcom.com>
@winkingturtle-vmw winkingturtle-vmw mentioned this issue Apr 19, 2024
Merged
1 task
winkingturtle-vmw added a commit that referenced this issue Apr 19, 2024
@winkingturtle-vmw @MarcPaquette
Remove rootless option for gdn
d012eed 
This feature has been abandoned and not working as expected.

Context: #196

Signed-off-by: Marc Paquette <marc.paquette@broadcom.com>
@winkingturtle-vmw winkingturtle-vmw mentioned this issue Apr 19, 2024
Merged
1 task
winkingturtle-vmw added a commit that referenced this issue Apr 19, 2024
@winkingturtle-vmw @MarcPaquette
Remove rootless option for gdn
d9ac237 
This feature has been abandoned and not working as expected.

Context: #196

Signed-off-by: Marc Paquette <marc.paquette@broadcom.com>
winkingturtle-vmw added a commit that referenced this issue Apr 23, 2024
@winkingturtle-vmw
Remove rootless option for gdn
6c077b4 
This feature has been abandoned and not working as expected.

Context: #196

Signed-off-by: Marc Paquette <marc.paquette@broadcom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs features
Projects
Application Runtime Platform Working Group
Status: Inbox
Garden
Scheduled
DEPRECATED App Platform - Garden Con...
Issues - Triage Complete. Needs Fix.
DEPRECATED - WG-Application-Runtime-P...
Old PRs and Issues (pre-project creat...
Milestone
Handover
Development

No branches or pull requests
1 participant
@gcapizzi