Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mergo dependency from envelope_processor #717

Open
bonzofenix opened this issue Jul 1, 2022 · 1 comment
Open

Remove mergo dependency from envelope_processor #717

bonzofenix opened this issue Jul 1, 2022 · 1 comment
Labels
backlog Will be taken care of when time allows enhancement

Comments

@bonzofenix
Copy link
Contributor

Currently, we are using mergo library in the envelope_processor.go component. Mergo interface returns an error if it errors while merging 2 structs. This error could be avoided by removing Mergo and using built-in clone to merge structs by value.
@joergdw
Copy link
Contributor

joergdw commented Oct 28, 2022

We'll handle this issue in the future, currently it is not our highest priority.

@silvestre silvestre added the backlog Will be taken care of when time allows label Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog Will be taken care of when time allows enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bonzofenix @silvestre @joergdw